Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix cudf.Series constructor to handle list of sequences #8735

Merged
merged 13 commits into from
Jul 20, 2021
Merged

[REVIEW] Fix cudf.Series constructor to handle list of sequences #8735

merged 13 commits into from
Jul 20, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #7840
Dependent on: dask/dask#7892

This PR introduces ability to construct list Series by passing in a sequence of array-like objects to cudf.Series.

@galipremsagar galipremsagar added the 2 - In Progress Currently a work in progress label Jul 13, 2021
@galipremsagar galipremsagar self-assigned this Jul 13, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 13, 2021
@galipremsagar galipremsagar changed the title [WIP] Fix GroupBy.unique in dask_cudf [WIP] Fix cudf.Series constructor to handle list of sequences Jul 13, 2021
@galipremsagar galipremsagar changed the title [WIP] Fix cudf.Series constructor to handle list of sequences [REVIEW] Fix cudf.Series constructor to handle list of sequences Jul 13, 2021
@galipremsagar galipremsagar marked this pull request as ready for review July 13, 2021 23:23
@galipremsagar galipremsagar requested review from a team as code owners July 13, 2021 23:23
@galipremsagar galipremsagar requested review from marlenezw, skirui-source and shwina and removed request for marlenezw and skirui-source July 13, 2021 23:23
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels Jul 13, 2021
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Jul 13, 2021
@jakirkham jakirkham requested a review from rjzamora July 15, 2021 22:53
@galipremsagar
Copy link
Contributor Author

rerun tests

rjzamora
rjzamora reviewed Jul 16, 2021
View reviewed changes
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
python/dask_cudf/dask_cudf/tests/test_groupby.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 19, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@00f8dfb). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8735   +/-   ##
===============================================
  Coverage                ?   10.49%           
===============================================
  Files                   ?      116           
  Lines                   ?    18985           
  Branches                ?        0           
===============================================
  Hits                    ?     1993           
  Misses                  ?    16992           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f8dfb...4257f26. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

rerun tests

rjzamora
rjzamora approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Thanks @galipremsagar !

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 20, 2021
@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 456f088 into rapidsai:branch-21.08 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbluca charlesbluca charlesbluca approved these changes

@rjzamora rjzamora rjzamora approved these changes

@shwina shwina shwina approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Groupby collect_set / unique fails with Dask
4 participants
@galipremsagar @shwina @rjzamora @charlesbluca