Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNI build no longer looks for Arrow in conda environment #8686

Merged
merged 2 commits into from
Jul 8, 2021
Merged

JNI build no longer looks for Arrow in conda environment #8686

merged 2 commits into from
Jul 8, 2021

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Jul 7, 2021 •
edited
Loading

Updates the Java bindings native build to no longer look for the Arrow dependency in the conda environment. It now expects to find it in the libcudf build area or under the ARROW_ROOT environment variable if the user has specified it.

@jlowe jlowe added bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels Jul 7, 2021
@jlowe jlowe self-assigned this Jul 7, 2021
@jlowe jlowe requested a review from a team as a code owner July 7, 2021 22:03
@jlowe jlowe changed the title JNI build prefers libcudf Arrow dependency over conda package JNI build no longer looks for Arrow in conda environment Jul 7, 2021
mythrocks
mythrocks approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f0f2170). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 83866b9 differs from pull request most recent head bd22ce4. Consider uploading reports for the commit bd22ce4 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8686   +/-   ##
===============================================
  Coverage                ?   10.62%           
===============================================
  Files                   ?      109           
  Lines                   ?    18289           
  Branches                ?        0           
===============================================
  Hits                    ?     1943           
  Misses                  ?    16346           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f2170...bd22ce4. Read the comment docs.

@jlowe
Copy link
Member Author

jlowe commented Jul 8, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b123eb8 into rapidsai:branch-21.08 Jul 8, 2021
@jlowe jlowe deleted the jni-arrow-hint branch September 10, 2021 15:47
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhushukla kuhushukla kuhushukla approved these changes

@mythrocks mythrocks mythrocks approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working CMake CMake build issue Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlowe @trxcllnt @mythrocks @kuhushukla @vyasr