Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle arbitrarily different data in null list column rows when checking for equivalency. #8666

Merged
merged 9 commits into from
Jul 20, 2021
Merged

Handle arbitrarily different data in null list column rows when checking for equivalency. #8666

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
66ad749
Rework column equivalency checks to handle list columns that have arb…
nvdbaranec Jul 6, 2021
affc15e
Add recursive property checking for struct columns. Add the ability t…
nvdbaranec Jul 8, 2021
1719caa
Merge branch 'branch-21.08' into list_equivalency
nvdbaranec Jul 12, 2021
adf178c
Cleanup some variable declarations and type usage.
nvdbaranec Jul 12, 2021
6f18fbd
PR review changes.
nvdbaranec Jul 14, 2021
0999a2c
Merge branch 'branch-21.08' into list_equivalency
nvdbaranec Jul 16, 2021
0769c92
Change equality and equivalence functions to return a bool instead of…
nvdbaranec Jul 16, 2021
0724a3d
Formatting changes from PR review.
nvdbaranec Jul 19, 2021
dbf338e
Merge branch 'branch-21.08' into list_equivalency
nvdbaranec Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions cpp/include/cudf_test/column_utilities.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@ namespace test {
*
* @param lhs The first column
* @param rhs The second column
* @param throw_on_fail If true, throw a cudf::logic error on failure instead of printing
*/
void expect_column_properties_equal(cudf::column_view const& lhs, cudf::column_view const& rhs);
void expect_column_properties_equal(cudf::column_view const& lhs,
cudf::column_view const& rhs,
bool throw_on_fail = false);
nvdbaranec marked this conversation as resolved.
Show resolved Hide resolved

/**
* @brief Verifies the property equivalence of two columns.
Expand All @@ -46,7 +49,8 @@ void expect_column_properties_equal(cudf::column_view const& lhs, cudf::column_v
* @param rhs The second column
*/
void expect_column_properties_equivalent(cudf::column_view const& lhs,
cudf::column_view const& rhs);
cudf::column_view const& rhs,
bool throw_on_fail = false);

/**
* @brief Verifies the element-wise equality of two columns.
Expand All @@ -56,10 +60,12 @@ void expect_column_properties_equivalent(cudf::column_view const& lhs,
* @param lhs The first column
* @param rhs The second column
* @param print_all_differences If true display all differences
* @param throw_on_fail If true, throw a cudf::logic error on failure instead of printing
*/
void expect_columns_equal(cudf::column_view const& lhs,
cudf::column_view const& rhs,
bool print_all_differences = false);
bool print_all_differences = false,
bool throw_on_fail = false);

/**
* @brief Verifies the element-wise equivalence of two columns.
Expand All @@ -70,10 +76,12 @@ void expect_columns_equal(cudf::column_view const& lhs,
* @param lhs The first column
* @param rhs The second column
* @param print_all_differences If true display all differences
* @param throw_on_fail If true, throw a cudf::logic error on failure instead of printing
*/
void expect_columns_equivalent(cudf::column_view const& lhs,
cudf::column_view const& rhs,
bool print_all_differences = false);
bool print_all_differences = false,
bool throw_on_fail = false);

/**
* @brief Verifies the bitwise equality of two device memory buffers.
Expand Down
Loading