Remove unused cudf::strings::create_offsets #8663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
2 - In Progress
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8663 +/- ##
===============================================
Coverage ? 10.53%
===============================================
Files ? 116
Lines ? 18916
Branches ? 0
===============================================
Hits ? 1993
Misses ? 16923
Partials ? 0 Continue to review full report at Codecov.
|
vuule
approved these changes
Jul 9, 2021
davidwendt
added
3 - Ready for Review
jrhemstad
approved these changes
Jul 19, 2021
ttnghia
approved these changes
Jul 19, 2021
Comment on lines
+202
to
+209
| auto const scv = strings_column_view(c); | ||
| auto const h_chars = cudf::detail::make_std_vector_sync<char>( | ||
| cudf::device_span<char const>(scv.chars().data<char>(), scv.chars().size()), | ||
| rmm::cuda_stream_default); | ||
| auto const h_offsets = cudf::detail::make_std_vector_sync( | ||
| cudf::device_span<cudf::offset_type const>( | ||
| scv.offsets().data<cudf::offset_type>() + scv.offset(), scv.size() + 1), | ||
| rmm::cuda_stream_default); |
There was a problem hiding this comment.
Humm, I think we should better use 2 calls to make_vector_async then call stream sync, because 2 calls to make_vector_sync will make 2 implicit stream syncs.
Nevertheless, this is in the test namespace thus I'm not worried much about performance.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
create_offsetsstrings API was created and ported from NVStrings for use in interchanging data with the cuDF python layer. This API no longer appears to be used or required. Removing it simplifies thestrings_column_view.hppwhich is included by many libcudf source files.The only dependency was in some gtests files which were also updated in this PR.
The change is marked 'breaking' since a public API is being removed.