Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Struct scalar from host dictionary #8629

Merged
merged 8 commits into from
Jul 9, 2021
Merged

Struct scalar from host dictionary #8629

merged 8 commits into from
Jul 9, 2021

Conversation

shaneding
Copy link
Contributor

@shaneding shaneding commented Jun 29, 2021 •
edited
Loading

Allows the creation of a struct_scalar from python dictionary. Partly addresses #8558.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 29, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@de8d8d0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8629   +/-   ##
===============================================
  Coverage                ?   10.63%           
===============================================
  Files                   ?      109           
  Lines                   ?    18666           
  Branches                ?        0           
===============================================
  Hits                    ?     1985           
  Misses                  ?    16681           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de8d8d0...28c539a. Read the comment docs.

@shaneding shaneding added feature request New feature or request non-breaking Non-breaking change labels Jul 6, 2021
@shaneding shaneding marked this pull request as ready for review July 6, 2021 14:39
@shaneding shaneding requested a review from a team as a code owner July 6, 2021 14:39
brandon-b-miller
brandon-b-miller requested changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions but looking great.

@rgsl888prabhu rgsl888prabhu added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 9, 2021
@shaneding
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@brandon-b-miller
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cef51bd into rapidsai:branch-21.08 Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaneding @brandon-b-miller @rgsl888prabhu