Fix bug that columns only initialized once when specified columns and index in dataframe ctor
#8628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rerun tests |
galipremsagar
added
the
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8628 +/- ##
===============================================
Coverage ? 10.64%
===============================================
Files ? 109
Lines ? 18609
Branches ? 0
===============================================
Hits ? 1980
Misses ? 16629
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8621
This PR fixes a bug when initializing dataframe with
columnsandindexparameters, the columns are only initialized once. Leading to all columns are pointing to the same object.