Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NVBench in CMake #8619

Merged
merged 10 commits into from
Jun 30, 2021
Merged

Add NVBench in CMake #8619

merged 10 commits into from
Jun 30, 2021

Conversation

PointKernel
Copy link
Member

This PR added NVBench in cudf's CMake config file.

@PointKernel PointKernel added CMake CMake build issue non-breaking Non-breaking change labels Jun 28, 2021
@PointKernel PointKernel requested a review from a team as a code owner June 28, 2021 16:28
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 28, 2021
robertmaynard
robertmaynard requested changes Jun 28, 2021
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@PointKernel PointKernel requested a review from jrhemstad June 28, 2021 17:43
@codecov
Copy link

codecov bot commented Jun 28, 2021 •
edited
Loading

Codecov Report

Merging #8619 (bb0cc86) into branch-21.08 (1e53776) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-21.08    #8619    +/-   ##
==============================================
  Coverage         10.62%   10.62%            
==============================================
  Files               109      109            
  Lines             18246    18627   +381     
==============================================
+ Hits               1938     1980    +42     
- Misses            16308    16647   +339
Impacted Files Coverage Δ
python/cudf/cudf/io/hdf.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/orc.py 0.00% <0.00%> (ø)
python/cudf/cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/abc.py 0.00% <0.00%> (ø)
python/cudf/cudf/api/types.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/dlpack.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/frame.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/index.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 0.00% <0.00%> (ø)
python/cudf/cudf/io/parquet.py 0.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e53776...bb0cc86. Read the comment docs.

@PointKernel PointKernel requested a review from a team as a code owner June 28, 2021 20:02
@PointKernel PointKernel requested a review from vuule June 28, 2021 20:02
@PointKernel PointKernel added the feature request New feature or request label Jun 29, 2021
@PointKernel
Copy link
Member Author

@gpucibot merge

1 similar comment
@jrhemstad
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 96af10e into rapidsai:branch-21.08 Jun 30, 2021
@PointKernel PointKernel deleted the nvbench-cmake branch June 30, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@vuule vuule Awaiting requested review from vuule

Assignees
No one assigned
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @jrhemstad @robertmaynard