Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default datetime index resolution to ns to match pandas #8611

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 25, 2021

The default datetime resolution in cudf has been ms since we introduced datetimes because we did not initially support different resolutions. Now we can change this to match pandas.

@vyasr vyasr added feature request New feature or request 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. breaking Breaking change labels Jun 25, 2021
@vyasr vyasr self-assigned this Jun 25, 2021
@vyasr vyasr requested a review from a team as a code owner June 25, 2021 19:05
@vyasr vyasr requested review from shwina and isVoid June 25, 2021 19:05
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@0c64d0d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ecf4e69 differs from pull request most recent head acb536e. Consider uploading reports for the commit acb536e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8611   +/-   ##
===============================================
  Coverage                ?   83.00%           
===============================================
  Files                   ?      109           
  Lines                   ?    18239           
  Branches                ?        0           
===============================================
  Hits                    ?    15140           
  Misses                  ?     3099           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c64d0d...acb536e. Read the comment docs.

@vyasr
Copy link
Contributor Author

vyasr commented Jun 28, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 9510ef6 into rapidsai:branch-21.08 Jun 28, 2021
@vyasr vyasr added this to the cuDF Python Refactoring milestone Jul 22, 2021
@vyasr vyasr deleted the feature/datetime_resolution_ns branch January 14, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants