Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orc_reader_benchmark.cpp compile error #8609

Merged

Conversation

davidwendt
Copy link
Contributor

Recent changes in #8142 causes the cpp/benchmarks/io/orc/orc_reader_benchmark.cpp compile to fail

Building CXX object benchmarks/CMakeFiles/ORC_READER_BENCH.dir/io/orc/orc_reader_benchmark.cpp.o
FAILED: benchmarks/CMakeFiles/ORC_READER_BENCH.dir/io/orc/orc_reader_benchmark.cpp.o 
/usr/local/bin/g++ -DCUDF_VERSION=21.08.00 -DGTEST_LINKED_AS_SHARED_LIBRARY=1 -DJITIFY_USE_CACHE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_INFO -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -I../benchmarks -I../ -I../src -I_deps/benchmark-src/src/../include -I_deps/jitify-src -I_deps/libcudacxx-src/include -I../include -Iinclude -I_deps/thrust-src -I_deps/thrust-src/dependencies/cub -isystem /conda/envs/rapids/include -isystem /usr/local/cuda/include -O3 -DNDEBUG -fPIE -Wall -Werror -Wno-unknown-pragmas -Wno-error=deprecated-declarations -Wno-deprecated-declarations -pthread -std=gnu++1z -MD -MT benchmarks/CMakeFiles/ORC_READER_BENCH.dir/io/orc/orc_reader_benchmark.cpp.o -MF benchmarks/CMakeFiles/ORC_READER_BENCH.dir/io/orc/orc_reader_benchmark.cpp.o.d -o benchmarks/CMakeFiles/ORC_READER_BENCH.dir/io/orc/orc_reader_benchmark.cpp.o -c ../benchmarks/io/orc/orc_reader_benchmark.cpp
../benchmarks/io/orc/orc_reader_benchmark.cpp: In function ‘void BM_orc_read_varying_options(benchmark::State&)’:
../benchmarks/io/orc/orc_reader_benchmark.cpp:127:36: error: cannot convert ‘vector<int>’ to ‘vector<std::vector<int>>’
  127 |           read_options.set_stripes(stripes_to_read);
      |                                    ^~~~~~~~~~~~~~~
      |                                    |
      |                                    vector<int>
In file included from ../benchmarks/io/orc/orc_reader_benchmark.cpp:24:
../include/cudf/io/orc.hpp:145:56: note:   initializing argument 1 of ‘void cudf::io::orc_reader_options::set_stripes(std::vector<std::vector<int> >)’
  145 |   void set_stripes(std::vector<std::vector<size_type>> stripes)
      |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~

This PR fixes the call to read_options.set_stripes in the source file.

@davidwendt davidwendt added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 25, 2021
@davidwendt davidwendt self-assigned this Jun 25, 2021
@davidwendt davidwendt requested a review from a team as a code owner June 25, 2021 14:14
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #8609 (95c5ef2) into branch-21.08 (58438c0) will increase coverage by 0.36%.
The diff coverage is n/a.

❗ Current head 95c5ef2 differs from pull request most recent head e825086. Consider uploading reports for the commit e825086 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8609      +/-   ##
================================================
+ Coverage         82.63%   83.00%   +0.36%     
================================================
  Files               109      109              
  Lines             17869    18222     +353     
================================================
+ Hits              14766    15125     +359     
+ Misses             3103     3097       -6     
Impacted Files Coverage Δ
python/cudf/cudf/core/abc.py 86.36% <0.00%> (-1.45%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/fuzzer.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/hash_vocab_utils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58438c0...e825086. Read the comment docs.

@davidwendt
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 0c64d0d into rapidsai:branch-21.08 Jun 25, 2021
@davidwendt davidwendt deleted the bug-orc-reader-benchmark-compile branch June 25, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants