Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite binary operations for improved performance and additional type support #8598

Merged
merged 36 commits into from
Jul 15, 2021
Merged

Rewrite binary operations for improved performance and additional type support #8598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
4fa8ba9
Initial version of classmethod for DataFrame to handle binops without…
vyasr Jun 16, 2021
a7cd243
Use a single dict of pairs of operands.
vyasr Jun 17, 2021
65273dc
Fix nan behavior when adding a DataFrame to a Series.
vyasr Jun 17, 2021
eae97a8
Some minor simplifications.
vyasr Jun 17, 2021
d877f9f
Sketch out new tests that need to be added based on bugs in existing …
vyasr Jun 17, 2021
5e58821
Use faster indexers wherever possible.
vyasr Jun 19, 2021
955f853
Some cleanup and use standard method for checking scalars.
vyasr Jun 20, 2021
d2c2e64
Remove TODOs that have been addressed.
vyasr Jun 21, 2021
2a49b41
Start switching over binops to new function.
vyasr Jun 21, 2021
87a7001
Fix truediv compatibility.
vyasr Jun 21, 2021
1e76023
Convert reflected ops.
vyasr Jun 21, 2021
905509a
Add support for fill_value, enable user-facing binop methods, and fix…
vyasr Jun 21, 2021
1dbc7e8
Convert comparison operators.
vyasr Jun 21, 2021
6ed14cc
Add support for bitwise operations.
vyasr Jun 21, 2021
7c7f465
Introduce unary operator API to DataFrame and remove now unnecessary …
vyasr Jun 21, 2021
36e455f
Move _colwise_binop to Frame.
vyasr Jun 21, 2021
5047d8c
Switch series and index binops to use new framework.
vyasr Jun 22, 2021
59616ec
Remove bitwise binop wrapper.
vyasr Jun 22, 2021
8e0fed2
Move all binop definitions to Frame.
vyasr Jun 22, 2021
5cf32a2
Remove now unnecessary _copy_construct method from everything except …
vyasr Jun 22, 2021
f4be08a
Add docstrings and do some cleanup.
vyasr Jun 22, 2021
8b421ac
More cleanup, move unaryop to parent.
vyasr Jun 22, 2021
23e70e4
Remove now unnecessary global and move another to the one place that …
vyasr Jun 22, 2021
6b8ea36
Minor comment.
vyasr Jun 22, 2021
a38846b
Remove now unused _normalize_binop_value.
vyasr Jun 23, 2021
43069a1
Reintroduce copy_construct to maintain fast construction for Series/I…
vyasr Jun 23, 2021
a5cf8f3
Fix behavior of __mul__ for RangeIndex with ints.
vyasr Jun 23, 2021
d8ed528
Add tests for new features.
vyasr Jun 23, 2021
9495165
Merge remote-tracking branch 'origin/branch-21.08' into refactor/data…
vyasr Jun 24, 2021
3a6c2fe
Bypass binop for all null output.
vyasr Jun 24, 2021
86429b1
Merge remote-tracking branch 'origin/branch-21.08' into refactor/data…
vyasr Jun 25, 2021
54fc498
Merge remote-tracking branch 'origin/branch-21.08' into refactor/data…
vyasr Jun 29, 2021
9723699
Add type hints.
vyasr Jun 29, 2021
6445b19
Try fixing type ignore.
vyasr Jun 29, 2021
db3d1c3
Merge remote-tracking branch 'origin/branch-21.08' into refactor/data…
vyasr Jul 15, 2021
ab08ca8
Alias numpy issubdtype.
vyasr Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/cudf/cudf/api/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ def is_scalar(val):
return (
isinstance(val, DeviceScalar)
or isinstance(val, cudf.Scalar)
or isinstance(val, cudf.core.tools.datetimes.DateOffset)
brandon-b-miller marked this conversation as resolved.
Show resolved Hide resolved
or pd_types.is_scalar(val)
)

Expand Down Expand Up @@ -267,3 +268,7 @@ def _union_categoricals(
is_re = pd_types.is_re
is_re_compilable = pd_types.is_re_compilable
is_dtype_equal = pd_types.is_dtype_equal


# Aliases of numpy dtype functionality.
issubdtype = np.issubdtype
Loading