Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] User specified decimal columns to float64 #8587

Merged
merged 15 commits into from
Jun 28, 2021
Merged

[REVIEW] User specified decimal columns to float64 #8587

merged 15 commits into from
Jun 28, 2021

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Jun 22, 2021

Until Decimal128 is supported there are situations where users might have ORC files that contain larger than Decimal64 types. In this situation they may desire to convert those values to Float64. This PR allows for them to specify a list of column names they wish to do that for.

@jdye64 jdye64 requested review from a team as code owners June 22, 2021 19:35
@github-actions github-actions bot added Python Affects Python cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jun 22, 2021
@vuule vuule added feature request New feature or request non-breaking Non-breaking change labels Jun 22, 2021
@vuule vuule added the cuIO cuIO issue label Jun 22, 2021
@jdye64
Copy link
Contributor Author

jdye64 commented Jun 22, 2021

rerun tests

@vuule vuule requested a review from rgsl888prabhu June 22, 2021 20:35
@randerzander randerzander changed the title User specified decimal columns to float64 [REVIEW] User specified decimal columns to float64 Jun 22, 2021
@randerzander randerzander added the 3 - Ready for Review Ready for review by team label Jun 22, 2021
vuule
vuule requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, Jeremy :)
Got some suggestions to tighten up C++ code & testing.

cpp/include/cudf/io/orc.hpp Outdated Show resolved Hide resolved
cpp/include/cudf/io/orc.hpp Outdated Show resolved Hide resolved
cpp/src/io/orc/reader_impl.cu Outdated Show resolved Hide resolved
cpp/src/io/orc/reader_impl.cu Outdated Show resolved Hide resolved
cpp/src/io/orc/reader_impl.cu Outdated Show resolved Hide resolved
cpp/src/io/orc/reader_impl.cu Outdated Show resolved Hide resolved
cpp/src/io/orc/reader_impl.cu Outdated Show resolved Hide resolved
cpp/src/io/orc/stripe_data.cu Show resolved Hide resolved
python/cudf/cudf/tests/test_orc.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_orc.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 22, 2021 •
edited
Loading

Codecov Report

Merging #8587 (0ce919e) into branch-21.08 (58438c0) will increase coverage by 0.37%.
The diff coverage is n/a.

❗ Current head 0ce919e differs from pull request most recent head cc80693. Consider uploading reports for the commit cc80693 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8587      +/-   ##
================================================
+ Coverage         82.63%   83.01%   +0.37%     
================================================
  Files               109      109              
  Lines             17869    18225     +356     
================================================
+ Hits              14766    15129     +363     
+ Misses             3103     3096       -7
Impacted Files Coverage Δ
python/cudf/cudf/io/orc.py 88.09% <ø> (+0.07%) ⬆️
python/cudf/cudf/utils/ioutils.py 79.04% <ø> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58438c0...cc80693. Read the comment docs.

@jdye64 jdye64 requested review from vuule and brandon-b-miller June 23, 2021 15:14
@rgsl888prabhu
Copy link
Contributor

C++ looks good

@rgsl888prabhu
Copy link
Contributor

@brandon-b-miller @galipremsagar

@jdye64 jdye64 requested a review from brandon-b-miller June 23, 2021 19:47
@vuule vuule added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 23, 2021
@vuule
Copy link
Contributor

vuule commented Jun 23, 2021

rerun tests

vuule
vuule reviewed Jun 25, 2021
View reviewed changes
cpp/include/cudf/io/orc.hpp Outdated Show resolved Hide resolved
@rgsl888prabhu
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5f11b76 into rapidsai:branch-21.08 Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@rgsl888prabhu rgsl888prabhu rgsl888prabhu approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

@galipremsagar galipremsagar Awaiting requested review from galipremsagar

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdye64 @rgsl888prabhu @vuule @brandon-b-miller @randerzander