Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strings_count parameter from cudf::strings::detail::create_chars_child_column #8576

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Remove strings_count parameter from cudf::strings::detail::create_chars_child_column #8576

merged 2 commits into from
Jun 22, 2021

Conversation

davidwendt
Copy link
Contributor

Closes #8559

The strings_count parameter was necessary in a previous version of the cudf::strings::detail::create_chars_child_column but has become obsolete. This PR removes the parameter and fixes up the calls to the utility.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. tech debt non-breaking Non-breaking change labels Jun 21, 2021
@davidwendt davidwendt self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@f71c6fe). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8ca9915 differs from pull request most recent head e12a715. Consider uploading reports for the commit e12a715 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8576   +/-   ##
===============================================
  Coverage                ?   82.99%           
===============================================
  Files                   ?      109           
  Lines                   ?    18212           
  Branches                ?        0           
===============================================
  Hits                    ?    15115           
  Misses                  ?     3097           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71c6fe...e12a715. Read the comment docs.

@davidwendt davidwendt added improvement Improvement / enhancement to an existing function 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jun 21, 2021
@davidwendt davidwendt marked this pull request as ready for review June 21, 2021 23:24
@davidwendt davidwendt requested a review from a team as a code owner June 21, 2021 23:24
karthikeyann
karthikeyann approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@harrism
Copy link
Member

harrism commented Jun 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 15cd690 into rapidsai:branch-21.08 Jun 22, 2021
@davidwendt davidwendt deleted the remove-unused-parameter branch June 22, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism harrism approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove redundant parameter in strings::detail::create_chars_child_column
4 participants
@davidwendt @harrism @karthikeyann @ttnghia