Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for strings containing special JSON characters in get_json_object(). #8556

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

nvdbaranec
Copy link
Contributor

Fixes #8387

Also adds proper handling for valid JSON escape sequences in strings.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tract_element(). Add proper support for valid JSON escape sequences to parse_string.
@nvdbaranec nvdbaranec added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jun 18, 2021
@nvdbaranec nvdbaranec requested a review from a team as a code owner June 18, 2021 18:18
@nvdbaranec nvdbaranec requested review from cwharris and jrhemstad June 18, 2021 18:19
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #8556 (8b06c13) into branch-21.08 (709adb1) will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8556      +/-   ##
================================================
+ Coverage         82.53%   82.95%   +0.42%     
================================================
  Files               110      109       -1     
  Lines             17739    18173     +434     
================================================
+ Hits              14640    15076     +436     
+ Misses             3099     3097       -2     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/interval.py 83.67% <0.00%> (-5.69%) ⬇️
python/cudf/cudf/core/dtypes.py 93.52% <0.00%> (-1.51%) ⬇️
python/cudf/cudf/core/column/struct.py 93.65% <0.00%> (-1.18%) ⬇️
python/cudf/cudf/io/json.py 95.65% <0.00%> (-0.90%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.49% <0.00%> (-0.39%) ⬇️
python/cudf/cudf/core/column/column.py 87.64% <0.00%> (-0.15%) ⬇️
python/dask_cudf/dask_cudf/io/csv.py 95.65% <0.00%> (-0.07%) ⬇️
python/cudf/cudf/__init__.py 100.00% <0.00%> (ø)
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/ioutils.py 79.02% <0.00%> (ø)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709adb1...8b06c13. Read the comment docs.

@vuule
Copy link
Contributor

vuule commented Jun 19, 2021

rerun tests

// clang-format on
CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT(*result, expected);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

@nvdbaranec
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fa50b7d into rapidsai:branch-21.08 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
4 participants