-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for strings containing special JSON characters in get_json_object(). #8556
Fix for strings containing special JSON characters in get_json_object(). #8556
Conversation
…tract_element(). Add proper support for valid JSON escape sequences to parse_string.
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8556 +/- ##
================================================
+ Coverage 82.53% 82.95% +0.42%
================================================
Files 110 109 -1
Lines 17739 18173 +434
================================================
+ Hits 14640 15076 +436
+ Misses 3099 3097 -2
Continue to review full report at Codecov.
|
rerun tests |
// clang-format on | ||
CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT(*result, expected); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
@gpucibot merge |
Fixes #8387
Also adds proper handling for valid JSON escape sequences in strings.