Add Java methods to split and write column views [skip ci] #8546
Conversation
* Split returns a ColumnView in cases where we don't need to own the underlying buffers * Added a method to write ColumnView to parquet directly, circumventing the formation of Table with ColumnVectors
razajafri
changed the title
razajafri
added
improvement
|
build |
| if (DEFINED ENV{CUDF_CPP_BUILD_DIR}) | ||
| set(CUDF_CPP_BUILD_DIR "$ENV{CUDF_CPP_BUILD_DIR}") | ||
| else() | ||
| set(CUDF_CPP_BUILD_DIR "${CUDF_SOURCE_DIR}/build") | ||
| endif() |
There was a problem hiding this comment.
I have tried to push this change a few times, this works fine on my workstation. Can someone please test this patch to see if it doesn't break the flow that most devs use?
There was a problem hiding this comment.
You should be able to test the nightly Java build environment by following the instructions in java/ci/README.md
There was a problem hiding this comment.
Looks like it passes?
2021-06-17 22:40:54 (3.44 MB/s) - 'gds-redistrib-0.95.1.tgz' saved [2143346/2143346]
Removing intermediate container 16dfd7215a18
---> bb7efd8d7571
Successfully built bb7efd8d7571
Successfully tagged cudf-build:11.2.2-devel-centos7
There was a problem hiding this comment.
so, the above was just building the docker, I followed the instructions and CI is building with my PR. Thank you for this @jlowe
jlowe
changed the title
| if (DEFINED ENV{CUDF_CPP_BUILD_DIR}) | ||
| set(CUDF_CPP_BUILD_DIR "$ENV{CUDF_CPP_BUILD_DIR}") | ||
| else() | ||
| set(CUDF_CPP_BUILD_DIR "${CUDF_SOURCE_DIR}/build") | ||
| endif() |
There was a problem hiding this comment.
You should be able to test the nightly Java build environment by following the instructions in java/ci/README.md
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8546 +/- ##
===============================================
Coverage ? 82.59%
===============================================
Files ? 109
Lines ? 17858
Branches ? 0
===============================================
Hits ? 14750
Misses ? 3108
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
This PR pertains to making a couple of optimizations needed to support cases when the formation of a vector isn't needed for operations.