Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudf_kafka explicitly search for a matching patch version of cudf #8543

Conversation

robertmaynard
Copy link
Contributor

This fixes issues where cudf_kafka tries to search for/build an older cudf patch version. ( 21.06.01 searching for 21.06.00 )

@robertmaynard robertmaynard requested a review from a team as a code owner June 17, 2021 16:34
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jun 17, 2021
@robertmaynard robertmaynard changed the base branch from branch-21.08 to branch-21.06 June 17, 2021 16:34
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #8543 (fd38511) into branch-21.06 (2e780d0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-21.06    #8543   +/-   ##
=============================================
  Coverage         82.83%   82.83%           
=============================================
  Files               109      109           
  Lines             17896    17896           
=============================================
  Hits              14824    14824           
  Misses             3072     3072           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a1165...fd38511. Read the comment docs.

Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raydouglass raydouglass merged commit b5ffdf5 into rapidsai:branch-21.06 Jun 17, 2021
@robertmaynard robertmaynard deleted the use_correct_patch_version_when_searching branch August 13, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants