[REVIEW] Fix importing apply from dask
#8517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
bug
galipremsagar
changed the title
apply from dask.utilsapply from dask
|
@gpucibot merge |
galipremsagar
added
5 - Ready to Merge
|
rerun tests |
1 similar comment
|
rerun tests |
jakirkham
approved these changes
Jun 15, 2021
jakirkham
reviewed
Jun 15, 2021
Comment on lines
-78
to
+81
| logger "pip install git+https://github.com/dask/distributed.git@main --upgrade --no-deps" | ||
| pip install "git+https://github.com/dask/distributed.git@main" --upgrade --no-deps | ||
| logger "pip install git+https://github.com/dask/dask.git@main --upgrade --no-deps" | ||
| pip install "git+https://github.com/dask/dask.git@main" --upgrade --no-deps | ||
| logger "pip install git+https://github.com/dask/distributed.git@2021.06.0 --upgrade --no-deps" | ||
| pip install "git+https://github.com/dask/distributed.git@2021.06.0" --upgrade --no-deps | ||
| logger "pip install git+https://github.com/dask/dask.git@2021.06.0 --upgrade --no-deps" | ||
| pip install "git+https://github.com/dask/dask.git@2021.06.0" --upgrade --no-deps |
There was a problem hiding this comment.
Running benchmarks would fail with latest dask as streamz is currently broken: https://github.com/python-streamz/streamz/blob/master/streamz/dask.py#L7
Plan is to revert all the pinning once python-streamz/streamz#423 is merged. - The current pin is to unblock CI
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8517 +/- ##
===============================================
Coverage ? 82.89%
===============================================
Files ? 110
Lines ? 18097
Branches ? 0
===============================================
Hits ? 15002
Misses ? 3095
Partials ? 0 Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of dask/dask#7801,
applyhas been removed fromdask.compatibility, hence made changes indask_cudfto importapplyfromdask.utils, this change is back-ward compatible to older versions of dask too.