Incorrect map size in scatter_to_gather corrupts struct columns #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerashegalov
added
3 - Ready for Review
Simplifies copy_if_else by skipping gather on lhs, and using lhs directly as the rhs scatter destinations for 0-rows in select col. Closes rapidsai#8356 Co-authored-by: MithunR <[email protected]>
gerashegalov
force-pushed
the
copy_if_else_8356
branch
from
e9f8465 to
75faa03
Compare
gerashegalov
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8507 +/- ##
================================================
+ Coverage 82.53% 82.91% +0.38%
================================================
Files 110 110
Lines 17739 18094 +355
================================================
+ Hits 14640 15002 +362
+ Misses 3099 3092 -7
Continue to review full report at Codecov.
|
ttnghia
requested changes
Jun 14, 2021
ttnghia
approved these changes
Jun 14, 2021
harrism
approved these changes
Jun 14, 2021
mythrocks
approved these changes
Jun 14, 2021
|
@mythrocks I discussed with @sameerz and @revans2 and they agreed this is not needed in 21.06 because Spark has disabled this functionality in that release due to the issue fixed here. |
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jun 18, 2021
This PR is for #8281, since the bug has been fixed by #8507. So just enable the test. Authors: - Bobby Wang (https://github.com/wbo4958) Approvers: - Liangcai Li (https://github.com/firestarman) URL: #8548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the scatter map size to the target column size.
Simplifies
copy_if_elseby skipping gather on lhs, and using lhs directly as the rhs scatter destinations for 0-rows in select col.Closes #8356
Co-authored-by: @mythrocks