Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace_nulls properly propagates memory resource to gather calls #8500

Conversation

robertmaynard
Copy link
Contributor

As noted in https://github.com/rapidsai/cudf/pull/8483/files/48b4d97824a6dffd50fe795f698bc1876575f6c2#r650155797 the original code forgot to propagate the device_memory_resource to the detail::gather call.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 11, 2021
@robertmaynard robertmaynard requested a review from a team as a code owner June 11, 2021 17:48
@robertmaynard robertmaynard requested a review from harrism June 11, 2021 17:48
@robertmaynard robertmaynard requested a review from vuule June 11, 2021 17:48
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@0a4e8a1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 9096265 differs from pull request most recent head c55e8ea. Consider uploading reports for the commit c55e8ea to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8500   +/-   ##
===============================================
  Coverage                ?   82.90%           
===============================================
  Files                   ?      110           
  Lines                   ?    18091           
  Branches                ?        0           
===============================================
  Hits                    ?    14998           
  Misses                  ?     3093           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a4e8a1...c55e8ea. Read the comment docs.

@vuule
Copy link
Contributor

vuule commented Jun 12, 2021

@gpucibot merge

@robertmaynard
Copy link
Contributor Author

rerun tests

1 similar comment
@robertmaynard
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit fecd302 into rapidsai:branch-21.08 Jun 14, 2021
@robertmaynard robertmaynard deleted the bug/replace_nulls_propagate_memory_resource branch June 15, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants