-
Notifications
You must be signed in to change notification settings - Fork 927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialization methods for List
and StructDtype
#8441
Merged
rapids-bot
merged 10 commits into
rapidsai:branch-21.08
from
charlesbluca:add-dtype-serialization
Jun 21, 2021
+190
−67
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
27ac11d
Add serialization methods for list and struct dtypes
charlesbluca 99192fd
Refactor dtype serialization to always use type-serialized
charlesbluca 52c9054
Use list dtype serialization for list column serialization
charlesbluca b899fb2
Add tests for categorical columns, struct dtypes
charlesbluca 07174e3
Add handling for pyarrow -> cudf decimal type
charlesbluca af342ff
Have dtypes extend Serializable
charlesbluca 7cb557a
Move struct dtype test
charlesbluca b42cb79
Merge remote-tracking branch 'upstream/branch-21.08' into add-dtype-s…
charlesbluca 74c6661
Merge remote-tracking branch 'upstream/branch-21.08' into add-dtype-s…
charlesbluca bf948a1
Relocate serialization functions to correpsonding column tests
charlesbluca File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
_BaseDtype
extendSerializable
now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the changes, you've just added it should now. I'm actually not 100% sure what we should and shouldn't do with _BaseDtype. Ashwin is probably the right person to ask about this, though IMO this should be fine 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would agree. Our dtypes should probably all be
Serializable
.