Install only the same Thrust files that Thrust itself installs #8420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CMake
Fixes rapidsai#8397 Recreate thrust's install rules so we don't install extra directories such as `.git`. We can't leverage thrust's install rules as that would break our layout as the cmake files would need to go into something like `lib/cmake/cudf/thirdparty?/lib/cmake/thrust`. This weird path is required as cudf packages a modified version of Thrust and we don't want that to be installed into a default system path.
robertmaynard
force-pushed
the
bug/make_sure_to_only_install_the_good_thrust_bits
branch
from
bffafd0 to
837d8ad
Compare
harrism
approved these changes
Jun 2, 2021
|
rerun tests |
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.08 #8420 +/- ##
===============================================
Coverage ? 82.83%
===============================================
Files ? 109
Lines ? 17901
Branches ? 0
===============================================
Hits ? 14828
Misses ? 3073
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
robertmaynard
deleted the
bug/make_sure_to_only_install_the_good_thrust_bits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8397
Recreate thrust's install rules so we don't install extra directories such as
.git. We can't leverage thrust's install rules as that would break our layout as the cmake files would need to go into something likelib/cmake/cudf/thirdparty?/lib/cmake/thrust. This weird path is required as cudf packages a modified version of Thrust and we don't want that to be installed into a default system path.