Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for struct search #8396

Merged
merged 4 commits into from
Jun 3, 2021
Merged

Improve test coverage for struct search #8396

merged 4 commits into from
Jun 3, 2021

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented May 27, 2021

This PR adds a simple test case for struct binary search. In this test, we do binary search for 2 structs columns in which one column has a bit mask (but no null element) while the other column does not have any bit mask.

Reference: #8374 | #8187

@ttnghia ttnghia added feature request New feature or request tests Unit testing for project libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels May 27, 2021
@ttnghia ttnghia self-assigned this May 27, 2021
@ttnghia ttnghia requested review from a team as code owners May 27, 2021 22:35
@ttnghia ttnghia requested review from jrhemstad and codereport May 27, 2021 22:35
@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. labels May 27, 2021
@ttnghia ttnghia changed the base branch from branch-21.06 to branch-21.08 May 27, 2021 22:35
@ttnghia ttnghia removed request for a team May 27, 2021 22:35
@github-actions github-actions bot removed CMake CMake build issue Java Affects Java cuDF API. conda labels May 27, 2021
codereport
codereport approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@codereport codereport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ttnghia
Copy link
Contributor Author

ttnghia commented May 28, 2021

Rerun tests.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 1, 2021

Rerun tests.

1 similar comment
@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 1, 2021

Rerun tests.

@codecov
Copy link

codecov bot commented Jun 2, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@316831b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #8396   +/-   ##
===============================================
  Coverage                ?   82.83%           
===============================================
  Files                   ?      109           
  Lines                   ?    17901           
  Branches                ?        0           
===============================================
  Hits                    ?    14828           
  Misses                  ?     3073           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 316831b...ccae073. Read the comment docs.

@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 3, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit c2ec012 into rapidsai:branch-21.08 Jun 3, 2021
@ttnghia ttnghia deleted the Improve_tests_for_structs branch June 9, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@jrhemstad jrhemstad Awaiting requested review from jrhemstad

Assignees

@ttnghia ttnghia

Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttnghia @codereport