Handle empty results with nested types in copy_if_else #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvdbaranec
added
bug
|
rerun tests |
jrhemstad
approved these changes
May 26, 2021
ttnghia
approved these changes
May 26, 2021
| /** | ||
| * @brief Initializes and returns an empty column of the same type as the `input`. | ||
| * | ||
| * @param[in] input Scalar to emulate |
mythrocks
reviewed
May 26, 2021
|
Rerun tests. |
trxcllnt
approved these changes
May 26, 2021
mythrocks
approved these changes
May 26, 2021
|
@gpucibot merge |
|
Rerun tests. |
3 similar comments
|
Rerun tests. |
|
Rerun tests. |
|
Rerun tests. |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8359 +/- ##
===============================================
Coverage ? 82.86%
===============================================
Files ? 106
Lines ? 17874
Branches ? 0
===============================================
Hits ? 14811
Misses ? 3063
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8322
The code was calling
make_empty_column()to produce empty results, which does not work for nested types. Fix was to useempty_like()instead.As part of this, I implemented a new public function:
std::unique_ptr<column> empty_like(scalar const& input);