Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Raise NotImplementedError for axis=1 in rank #8347

Merged
merged 1 commit into from
May 26, 2021
Merged

[REVIEW] Raise NotImplementedError for axis=1 in rank #8347

merged 1 commit into from
May 26, 2021

Conversation

galipremsagar
Copy link
Contributor

Fixes: #8212

This PR raises an informative error when axis is not 0/index.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels May 25, 2021
@galipremsagar galipremsagar requested a review from kkraus14 May 25, 2021 14:25
@galipremsagar galipremsagar self-assigned this May 25, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 25, 2021 14:25
@galipremsagar galipremsagar requested a review from isVoid May 25, 2021 14:25
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 25, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 25, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@dd5eecd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8347   +/-   ##
===============================================
  Coverage                ?   82.88%           
===============================================
  Files                   ?      105           
  Lines                   ?    17877           
  Branches                ?        0           
===============================================
  Hits                    ?    14818           
  Misses                  ?     3059           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd5eecd...5e20f7c. Read the comment docs.

@rapids-bot rapids-bot bot merged commit e598361 into rapidsai:branch-21.06 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@isVoid isVoid Awaiting requested review from isVoid

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] DataFrame.rank() ignores axis option
2 participants
@galipremsagar @kkraus14