Fix structs column description in dev docs #8318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isVoid
added
doc
rgsl888prabhu
approved these changes
May 21, 2021
nvdbaranec
requested changes
May 21, 2021
Co-authored-by: nvdbaranec <[email protected]>
mythrocks
reviewed
May 21, 2021
|
Thanks for fixing this. I'm not sure how I missed this when reviewing the last doc PR. I guess I concentrated on the |
Co-authored-by: MithunR <[email protected]>
mythrocks
approved these changes
May 21, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8318 +/- ##
===============================================
Coverage ? 82.88%
===============================================
Files ? 105
Lines ? 17874
Branches ? 0
===============================================
Hits ? 14814
Misses ? 3060
Partials ? 0 Continue to review full report at Codecov.
|
isVoid
added
5 - Ready to Merge
harrism
approved these changes
May 25, 2021
nvdbaranec
approved these changes
May 25, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently structs column section of developer documentation mentions there's an offset column tied to its layout. This is not true and this PR fixes that.