JNI: Refactor the code of making column from scalar [skip ci] #8310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By replacing the JNI implementation with the corresponding cudf API `make_column_from_scalar`. Signed-off-by: Firestarman <[email protected]>
firestarman
added
Spark
|
LGTM |
|
I vierified locally, it is non-breaking for both cudf and plugin. |
wbo4958
approved these changes
May 21, 2021
revans2
approved these changes
May 21, 2021
jlowe
reviewed
May 21, 2021
jlowe
approved these changes
May 24, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR is to replace the JNI implementation with the corresponding cudf API
make_column_from_scalar.The PR #8185 has added the support for nested type, so it is ok to do this now.
Signed-off-by: Firestarman [email protected]