-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a common parent class for NumericalColumn and DecimalColumn #8278
Introduce a common parent class for NumericalColumn and DecimalColumn #8278
Conversation
@vyasr Looks like there are some test failures in |
Yes sorry I noticed this failure but I've been focusing on #8214 for the past few days. I should hit a good stopping point this afternoon to come back and wrap up my open Python PRs including this one. |
Marking this as breaking since we don't technically hide the Column class even though we don't intend for it to be part of our public API. |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8278 +/- ##
===============================================
Coverage ? 82.88%
===============================================
Files ? 106
Lines ? 17844
Branches ? 0
===============================================
Hits ? 14790
Misses ? 3054
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
Adds a common parent class for NumericalColumn and DecimalColumn that implements the common operations (mainly reductions and scans). As part of enabling this, the _copy_type_metadata method was refactored to have different column types override it to perform column-specific tasks (necessary because DecimalColumn has some special handling), which should also provide some marginal performance improvements for methods that copy metadata.
This PR (and some to follow) are designed to help simplify the ongoing Array refactoring.