Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Enable implicit casting when concatenating mixed types #8276

Merged
merged 3 commits into from
May 23, 2021
Merged

[REVIEW] Enable implicit casting when concatenating mixed types #8276

merged 3 commits into from
May 23, 2021

Conversation

ChrisJar
Copy link
Contributor

This enables implicit casting when decimal columns are concatenated with numeric columns by casting the numeric columns to decimal columns.

Closes #8264

@ChrisJar ChrisJar requested a review from a team as a code owner May 18, 2021 22:11
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 18, 2021
@codecov
Copy link

codecov bot commented May 19, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@6b09253). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8276   +/-   ##
===============================================
  Coverage                ?   82.87%           
===============================================
  Files                   ?      105           
  Lines                   ?    17856           
  Branches                ?        0           
===============================================
  Hits                    ?    14799           
  Misses                  ?     3057           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b09253...633fb89. Read the comment docs.

@ChrisJar ChrisJar requested a review from shwina May 21, 2021 19:12
shwina
shwina approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Awesome refactoring of some of the dtype handling too!

@shwina shwina added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 21, 2021
@shwina
Copy link
Contributor

shwina commented May 23, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 696902d into rapidsai:branch-21.06 May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@shwina shwina shwina approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Implicit typecasting between Decimal and Floats during concat
3 participants
@ChrisJar @shwina @brandon-b-miller