-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update io util to convert path like object to string #8275
Update io util to convert path like object to string #8275
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8275 +/- ##
===============================================
Coverage ? 82.84%
===============================================
Files ? 105
Lines ? 17865
Branches ? 0
===============================================
Hits ? 14800
Misses ? 3065
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
There seem to be errors the decimal orc writer tests unrelated to this pr. Might be a timing issue since the to_orc decimal support merged 4 hours back so it may not have made it to the libcudf build in CI |
Rerun tests |
Fixes failing dask-cudf s3 test introduced from changes to
fsspec.stringify_path
in their 2021.5.0 release.Problem description:
While reading remote files with dask-cudf the
path_or_object
param is populated with remote file objects such ass3fs.s3File
orgcsfs.GCSFile
. Updates to thefsspec.stringify_path
util results in returning the string path for such objects resulting in cudf looking for those file paths locally.Fix:
Fix uses one of the branches from the original
stringify_path
util that checks if apath like
object implement thefsspath
protocol and gets the string representation from that.