Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake FindPackage rmm, pin dev envs' dlpack to v0.3 #8271

Merged
merged 6 commits into from
May 18, 2021
Merged

Fix CMake FindPackage rmm, pin dev envs' dlpack to v0.3 #8271

merged 6 commits into from
May 18, 2021

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented May 18, 2021 •
edited
Loading

  • Fix CMake FindPackage rmm
  • Pin conda envs dlpack to v0.3

@trxcllnt trxcllnt requested review from a team as code owners May 18, 2021 13:00
@trxcllnt trxcllnt added non-breaking Non-breaking change 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function labels May 18, 2021
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels May 18, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 18, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@65e8372). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7b20bc6 differs from pull request most recent head 9527c6e. Consider uploading reports for the commit 9527c6e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8271   +/-   ##
===============================================
  Coverage                ?   82.85%           
===============================================
  Files                   ?      105           
  Lines                   ?    17891           
  Branches                ?        0           
===============================================
  Hits                    ?    14823           
  Misses                  ?     3068           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e8372...9527c6e. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 59d8d5e into rapidsai:branch-21.06 May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trxcllnt @kkraus14 @robertmaynard @jjacobelli