Return python lists for __getitem__ calls to list type series #8265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
brandon-b-miller
added
3 - Ready for Review
isVoid
reviewed
May 19, 2021
python/cudf/cudf/tests/test_list.py
Outdated
| def test_list_getitem(data): | ||
| list_sr = cudf.Series([data]) | ||
| # __getitem__ shall fill None with cudf.NA | ||
| assert pa.scalar(data) == list_sr.to_arrow()[0] |
There was a problem hiding this comment.
Is this actually testing our __getitem__ code path?
There was a problem hiding this comment.
oops :) fixed.
galipremsagar
approved these changes
May 20, 2021
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8265 +/- ##
===============================================
Coverage ? 82.84%
===============================================
Files ? 105
Lines ? 17865
Branches ? 0
===============================================
Hits ? 14800
Misses ? 3065
Partials ? 0 Continue to review full report at Codecov.
|
isVoid
approved these changes
May 20, 2021
brandon-b-miller
added
5 - Ready to Merge
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so that this works: