-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes CSV-reader type inference for thousands separator and decimal point #8261
Fixes CSV-reader type inference for thousands separator and decimal point #8261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, other than that looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the existing comment on testing 👍
79c2e55
to
a7e2715
Compare
@elstehle please don't force-push. If I remember correctly, it messes with the comment traceability. |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8261 +/- ##
===============================================
Coverage ? 82.84%
===============================================
Files ? 105
Lines ? 17865
Branches ? 0
===============================================
Hits ? 14800
Misses ? 3065
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
This PR fixes #6655
This PR also makes sure to respect a user-specified decimal point during type inference. I.e., when the decimal point is not '.', types are now correctly inferred.
Plus some minor doxygen fixes and style changes from camelCase to snake_case.