add unit tests for lead/lag on list for row window [skip ci] #8259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbo4958
changed the title
firestarman
added
feature request
|
LGTM |
|
LGTM, but some tests have failed. |
wbo4958
changed the title
mythrocks
reviewed
May 18, 2021
mythrocks
reviewed
May 18, 2021
mythrocks
reviewed
May 18, 2021
| @@ -3464,6 +3681,16 @@ void testRangeWindowingLead() { | |||
| .column(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1) // GBY Key | |||
| .column(0, 0, 0, 0, 1, 1, 1, 1, 2, 2, 2, 2, 2) // GBY Key | |||
| .column(7, 5, 1, 9, 7, 9, 8, 2, 8, 0, 6, 6, 8) // Agg Column | |||
| .column(new ListType(false, new BasicType(true, DType.INT32)), | |||
There was a problem hiding this comment.
Not a review suggestion. Just FYI: I think SparkSQL doesn't support calling LEAD()/LAG() on RANGE windows. It might be worth checking. This path might simply not get exercised from the spark-rapids plugin.
There was a problem hiding this comment.
Removed the lead/lag for range window test
mythrocks
reviewed
May 18, 2021
mythrocks
requested changes
May 18, 2021
Signed-off-by: Bobby Wang <[email protected]>
|
@mythrocks Could you help to check it |
mythrocks
approved these changes
May 19, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just added the unit tests for the lead/lag on List/Struct type for both Row-window and Range-window, Since libcudf has already supported the functionality. See the plugin feature request NVIDIA/spark-rapids#2012
But there is an issue when setting the default values for lead/lag on List/Struct. I just commented the corresponding assertation out. I will re-enable it after libcudf fixes it.