Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ORC statistics API to use C++17 standard library #8241

Merged
merged 3 commits into from
May 18, 2021

Conversation

vuule
Copy link
Contributor

@vuule vuule commented May 13, 2021

Uses std::optional instead of std::unique_ptr for optional ORC statistics fields, and std::variant instead of the manually implemented type erasure.
Removes a lot of code that simulated std::optional and std::variant when it wasn't available.

@vuule vuule self-assigned this May 13, 2021
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 13, 2021
@vuule vuule added breaking Breaking change cuIO cuIO issue improvement Improvement / enhancement to an existing function labels May 13, 2021
@vuule
Copy link
Contributor Author

vuule commented May 13, 2021

Breaking change because it modifies the type that read_parsed_orc_statistics returns.

@vuule vuule marked this pull request as ready for review May 13, 2021 23:05
@vuule vuule requested a review from a team as a code owner May 13, 2021 23:05
@vuule vuule requested review from trxcllnt and nvdbaranec May 13, 2021 23:05
@vuule
Copy link
Contributor Author

vuule commented May 14, 2021

Rerun tests

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@92f067d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8241   +/-   ##
===============================================
  Coverage                ?   84.47%           
===============================================
  Files                   ?      105           
  Lines                   ?    19976           
  Branches                ?        0           
===============================================
  Hits                    ?    16874           
  Misses                  ?     3102           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f067d...b82fff4. Read the comment docs.

@davidwendt davidwendt changed the title Update ORC statistics API to se C++17 standard library Update ORC statistics API to use C++17 standard library May 14, 2021
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how so much of this melted away.

@vuule
Copy link
Contributor Author

vuule commented May 16, 2021

I really like how so much of this melted away.

Yeah, I wrote so much code to approximate std::variant and std::optional functionality. So glad to be able to remove it :)

Copy link
Contributor

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@nvdbaranec nvdbaranec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@vuule
Copy link
Contributor Author

vuule commented May 18, 2021

rerun tests

@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 18, 2021
@vuule vuule changed the title Update ORC statistics API to use C++17 standard library Update ORC statistics API to use C++17 standard library May 18, 2021
@vuule
Copy link
Contributor Author

vuule commented May 18, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 56513a8 into rapidsai:branch-21.06 May 18, 2021
@vuule vuule deleted the fea-update-stats-api branch May 18, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants