-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ORC statistics API to use C++17 standard library #8241
Conversation
Breaking change because it modifies the type that |
Rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8241 +/- ##
===============================================
Coverage ? 84.47%
===============================================
Files ? 105
Lines ? 19976
Branches ? 0
===============================================
Hits ? 16874
Misses ? 3102
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how so much of this melted away.
Yeah, I wrote so much code to approximate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
rerun tests |
@gpucibot merge |
Uses
std::optional
instead ofstd::unique_ptr
for optional ORC statistics fields, andstd::variant
instead of the manually implemented type erasure.Removes a lot of code that simulated
std::optional
andstd::variant
when it wasn't available.