Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scattering integers into decimal columns #8225

Merged

Conversation

brandon-b-miller
Copy link
Contributor

Closes #8157

@brandon-b-miller brandon-b-miller added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. non-breaking Non-breaking change labels May 12, 2021
@brandon-b-miller brandon-b-miller requested a review from a team as a code owner May 12, 2021 17:39
@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #8225 (aff40e5) into branch-0.20 (51336df) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head aff40e5 differs from pull request most recent head a8e65ca. Consider uploading reports for the commit a8e65ca to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           branch-0.20    #8225    +/-   ##
=============================================
  Coverage        82.88%   82.89%            
=============================================
  Files              103      104     +1     
  Lines            17668    17920   +252     
=============================================
+ Hits             14645    14855   +210     
- Misses            3023     3065    +42     
Impacted Files Coverage Δ
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.47% <0.00%> (-2.46%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
python/cudf/cudf/core/column/struct.py 94.73% <0.00%> (-1.56%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.20% <0.00%> (-1.24%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 91.28% <0.00%> (-0.88%) ⬇️
python/cudf/cudf/core/series.py 91.17% <0.00%> (-0.56%) ⬇️
python/cudf/cudf/core/index.py 92.52% <0.00%> (-0.55%) ⬇️
python/cudf/cudf/core/column/column.py 88.20% <0.00%> (-0.44%) ⬇️
python/cudf/cudf/core/column/lists.py 87.09% <0.00%> (-0.32%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c70f1d...a8e65ca. Read the comment docs.

Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestion that you can feel free to ignore.

@kkraus14 kkraus14 added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 13, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6b92e25 into rapidsai:branch-0.20 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Support scattering int scalars into decimal columns
4 participants