-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve column hierarchy when getting NULL row from LIST
column
#8206
Preserve column hierarchy when getting NULL row from LIST
column
#8206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8206 +/- ##
===============================================
Coverage ? 82.83%
===============================================
Files ? 105
Lines ? 17861
Branches ? 0
===============================================
Hits ? 14796
Misses ? 3065
Partials ? 0 Continue to review full report at Codecov.
|
LIST
columnLIST
column.
LIST
column.LIST
column
…Default_list_scalar_bug
Don't know if I have cpp merge privilege so I'll test on this one. |
@gpucibot merge |
@isVoid You need to put the |
This PR fixes a bug introduced in #8071, when
get_element
retrieves a NULL row in a nested column, the scalar returned not only should beis_valid() == false
, but also should preserve the column hierarchy of the row-data, even they are invalid. Because depending libraries may use the column hierarchy to deduce the nested type of the column.This PR also reverts
make_default_constructed_scalar
API forLIST
type. ALIST
type scalar should have complete column hierarchy as part of its type information. There isn't enough information provided to the API to construct that.Another tiny addition: instead of hard coding the position of child column, use
list_column_view::child_column_index
intead.