Convert tests to use device_uvector #8205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r than std::vector
harrism
added
improvement
26 tasks
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8205 +/- ##
===============================================
- Coverage 82.88% 82.88% -0.01%
===============================================
Files 103 104 +1
Lines 17668 17907 +239
===============================================
+ Hits 14645 14843 +198
- Misses 3023 3064 +41
Continue to review full report at Codecov.
|
davidwendt
reviewed
May 11, 2021
robertmaynard
approved these changes
May 11, 2021
ttnghia
approved these changes
May 12, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all remaining tests to use device_uvector instead of device_vector.
Contributes to #7287
Also converts a lot of
std::vectorin tests tothrust::host_vectorto avoid problems withvector<bool>.Adds a new utility
cudf::detail::make_host_vector_async(and sync version) which creates athrust::host_vector<T>from adevice_span. Also makes it possible to create ahost_spanfrom astd::string.