-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix struct scatter to correctly cascade null_mask to children columns #8176
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8176 +/- ##
===============================================
- Coverage 82.88% 82.88% -0.01%
===============================================
Files 103 104 +1
Lines 17668 17894 +226
===============================================
+ Hits 14645 14832 +187
- Misses 3023 3062 +39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ttnghia, could we please change the PR title to be more descriptive? |
@gpucibot merge |
This fixes a bug in
scatter.cuh
where the struct column failed to cascade its null_mask to its children. Typically, this is automatically done during struct construction. Unfortunately, the current scatter function constructs a structs column first, then updates the parent null_mask later thus it fails to update its children's null_mask.