Code

Merge Index and Series binops#8166

Code

Merged

rapids-bot[bot] merged 35 commits intorapidsai:branch-0.20rapidsai/cudf:branch-0.20from vyasr:refactor/frame_binopsvyasr/cudf:refactor/frame_binopsCopy head branch name to clipboardMay 6, 2021

+313-299

Commits

Commits on May 3, 2021

• Rename Series._binaryop to _apply_op for consistency with DataFrame.

  vyasr

  committed
  ee12d29

• Simplify logic for DataFrame-Series binaryop.

  vyasr

  committed
  252c9e1

• Minor simplifications.

  vyasr

  committed
  f489c19

• Simplify construction of result columns list.

  vyasr

  committed
  9c0dc53

• Revert "Rename Series._binaryop to _apply_op for consistency with DataFrame."

  Show description for 19f1b69
  vyasr

  committed
  19f1b69

• Simplify null handling logic in binops.

  vyasr

  committed
  bc7585f

• More simplifications.

  vyasr

  committed
  00dffb5

• Move copy construct from series to frame.

  vyasr

  committed
  5cae0a4

• Add trivial internal method for index non-reflective binary ops (currently still a pass-through to Series).

  vyasr

  committed
  ddebce6

• Initial version of binary op for index.

  vyasr

  committed
  3f26b41

• Revert dataframe changes (restricting this PR to index and series only).

  vyasr

  committed
  8216e6c

• Basic working implementation of index binops.

  vyasr

  committed
  26e22ff

Commits on May 4, 2021

• Add tests for binary operations.

  vyasr

  committed
  946f6b1

• Centralize tests for index and series.

  vyasr

  committed
  e94b2cf

• Add reflected ops.

  vyasr

  committed
  c924936

• Enable null filling.

  vyasr

  committed
  e40814f

• Move most binary operations to SingleColumnFrame.

  vyasr

  committed
  fa11a6b

• Move binaryop implementation to SingleColumnFrame.

  vyasr

  committed
  ffcf6d8

• Reintroduce old null handling temporarily.

  vyasr

  committed
  829df17

• Override copy_construct for index to support returning a different index type.

  vyasr

  committed
  f2da7e1

• Fix behavior for bool and categorical dtype indices.

  vyasr

  committed
  a309ce5

• Move copy construct.

  vyasr

  committed
  522ee42

Commits on May 5, 2021

• Simplify the behavior for null filling again.

  vyasr

  committed
  64f92a6

• Remove now redundant tests.

  vyasr

  committed
  971ed93

• Handle various index dtypes correctly.

  vyasr

  committed
  ad9b1eb

• Handle correct types for RangeIndex binops.

  vyasr

  committed
  2274af6

• Fix kwargs for GenericIndex.

  vyasr

  committed
  a14b5eb

• Centralize _normalize_binop_value.

  vyasr

  committed
  6d07e15

• Move bitwise binops to frame so indexes can use directly.

  vyasr

  committed
  16aa1f8

• Move many more operators to SingleColumnFrame so they work on Index as well.

  vyasr

  committed
  12827ad

• Remove Index._apply_op entirely.

  vyasr

  committed
  9746376

• First pass at addressing PR comments.

  vyasr

  committed
  8a26869

• Use binop on column to avoid expensive isnull.

  vyasr

  committed
  de74ae1

• Switch string truediv types to dtypes.

  vyasr

  committed
  15e9458

• Error gracefully on attempts to perform bitwise binops with extension dtypes.

  vyasr

  committed
  a930a11