Add a flag for allowing single quotes in JSON strings.

[nvdbaranec]

Add a flag that allows get_json_object() to accept JSON with strings using single quotes. Also adds an explicit get_json_object_options struct for allowing the user to customize what behaviors they want.

Note: stripping quotes from individually returned string values has been left on as default.

[nvdbaranec]

Pinging @jlowe for any input on the flipping of the logic (previously, default behavior was Spark-specific, now it is the opposite and the plugin will need to set set_allow_single_quotes(true) and set_strip_quotes_from_single_strings(true) .

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@8406522). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-21.06    #8144   +/-   ##
===============================================
  Coverage                ?   82.84%           
===============================================
  Files                   ?      105           
  Lines                   ?    17865           
  Branches                ?        0           
===============================================
  Hits                    ?    14800           
  Misses                  ?     3065           
  Partials                ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8406522...a2b6005. Read the comment docs.

[trxcllnt]

Stripping the quotes from a string seems like the right thing to do by default for JSON:

const str = JSON.parse(`{"str":"foo"}`).str;

assert(str === `foo`) // str is `foo`, not `"foo"`

[nvdbaranec]

As per Paul's comment, #8144 (comment) I have switched the default behavior for stripping quotes on single-string return values back to the way they were. Note: allowing single-quotes is still off by default, so the Spark plugin will need to toggle this on.

[hyperbolic2346]

Looks good to me

[nvdbaranec]

Changing this to non-breaking as it won't alter existing behavior.

[nvdbaranec]

@gpucibot merge