Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable join results with size > INT32_MAX #8139

Merged
merged 9 commits into from
May 5, 2021
Merged

Enable join results with size > INT32_MAX #8139

merged 9 commits into from
May 5, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented May 3, 2021

Closes #8121

@shwina shwina requested a review from a team as a code owner May 3, 2021 12:10
@shwina shwina requested review from cwharris and hyperbolic2346 May 3, 2021 12:10
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 3, 2021
shwina
shwina commented May 3, 2021
View reviewed changes
cpp/tests/join/join_tests.cpp Outdated Show resolved Hide resolved
@shwina shwina added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review Ready for review by team labels May 3, 2021
jrhemstad
jrhemstad reviewed May 3, 2021
View reviewed changes
cpp/src/join/hash_join.cu Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 3, 2021 •
edited
Loading

Codecov Report

Merging #8139 (bea3d62) into branch-0.20 (51336df) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head bea3d62 differs from pull request most recent head d29908e. Consider uploading reports for the commit d29908e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8139      +/-   ##
===============================================
+ Coverage        82.88%   82.92%   +0.03%     
===============================================
  Files              103      104       +1     
  Lines            17668    17896     +228     
===============================================
+ Hits             14645    14840     +195     
- Misses            3023     3056      +33
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/parquet.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <ø> (ø)
python/cudf/cudf/core/abc.py 91.66% <ø> (+0.17%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 91.04% <0.00%> (-1.89%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <0.00%> (-1.88%) ⬇️
python/cudf/cudf/core/column/struct.py 94.73% <0.00%> (-1.56%) ⬇️
python/cudf/cudf/utils/dtypes.py 82.20% <0.00%> (-1.24%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 91.28% <0.00%> (-0.88%) ⬇️
python/cudf/cudf/core/column/column.py 88.20% <0.00%> (-0.44%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56428a...d29908e. Read the comment docs.

jrhemstad
jrhemstad reviewed May 3, 2021
View reviewed changes
cpp/src/join/hash_join.cu Outdated Show resolved Hide resolved
@shwina shwina requested review from a team as code owners May 4, 2021 12:02
@shwina shwina requested a review from galipremsagar May 4, 2021 12:02
robertmaynard
robertmaynard approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the CMake changes.

@github-actions github-actions bot added CMake CMake build issue conda Java Affects Java cuDF API. Python Affects Python cuDF API. labels May 4, 2021
@shwina shwina force-pushed the enable-large-joins branch from 645a40a to 1bbc98b Compare May 4, 2021 14:29
@github-actions github-actions bot removed the Python Affects Python cuDF API. label May 4, 2021
@github-actions github-actions bot removed Java Affects Java cuDF API. conda CMake CMake build issue labels May 4, 2021
@shwina shwina removed request for a team and galipremsagar May 4, 2021 15:10
@shwina
Copy link
Contributor Author

shwina commented May 4, 2021

Removed a bunch of review requests that were triggered due to a Git snafu on my part.

ttnghia
ttnghia requested changes May 4, 2021
View reviewed changes
cpp/src/join/hash_join.cuh Outdated Show resolved Hide resolved
ttnghia
ttnghia reviewed May 5, 2021
View reviewed changes
cpp/src/join/hash_join.cuh Outdated Show resolved Hide resolved
revans2
revans2 approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@shwina
Copy link
Contributor Author

shwina commented May 5, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8cba3b0 into rapidsai:branch-0.20 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@ttnghia ttnghia ttnghia approved these changes

@revans2 revans2 revans2 approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

@cwharris cwharris Awaiting requested review from cwharris

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] hash join gather maps limited by size_type
5 participants
@shwina @robertmaynard @revans2 @ttnghia @jrhemstad