Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set jitify cache file limit via an environment variable #8132

Merged
merged 8 commits into from
May 5, 2021
Merged

Allow users to set jitify cache file limit via an environment variable #8132

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c1b109
allow users to set jitify cache file limit via an environment variable
trxcllnt May 1, 2021
1b83c7d
Merge branch 'branch-0.20' of github.com:rapidsai/cudf into fea/confi…
cwharris May 4, 2021
f185430
add jit cache kernel limit envs for disk and process
cwharris May 4, 2021
a00e770
add comment to clarify jitify2 disk cache behavior
cwharris May 4, 2021
4fe351d
clarify jitify2 caching behavior comment
cwharris May 4, 2021
fc14bf0
update size_t->std::size_t and clarify comment in jit cache code
cwharris May 5, 2021
533961a
.
cwharris May 5, 2021
f1d46ae
Merge branch 'branch-0.20' of github.com:rapidsai/cudf into fea/confi…
trxcllnt May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions cpp/src/jit/cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
#include <boost/filesystem.hpp>
#include <jitify2.hpp>

#include <cstddef>

namespace cudf {
namespace jit {

Expand Down Expand Up @@ -102,6 +104,15 @@ std::string get_program_cache_dir()
#endif
}

void try_parse_numeric_env_var(size_t& result, char const* const env_name)
{
auto value = std::getenv(env_name);

if (value != nullptr) {
result = std::stoull(value); // fails if env var contains invalid value.
}
}

jitify2::ProgramCache<>& get_program_cache(jitify2::PreprocessedProgramData preprog)
{
static std::mutex caches_mutex{};
Expand All @@ -112,9 +123,23 @@ jitify2::ProgramCache<>& get_program_cache(jitify2::PreprocessedProgramData prep
auto existing_cache = caches.find(preprog.name());

if (existing_cache == caches.end()) {
auto res = caches.insert(
{preprog.name(),
std::make_unique<jitify2::ProgramCache<>>(100, preprog, nullptr, get_program_cache_dir())});
size_t kernel_limit_proc = std::numeric_limits<size_t>::max();
size_t kernel_limit_disk = std::numeric_limits<size_t>::max();

cwharris marked this conversation as resolved.
Show resolved Hide resolved
try_parse_numeric_env_var(kernel_limit_proc, "LIBCUDF_KERNEL_CACHE_LIMIT_PER_PROCESS");
try_parse_numeric_env_var(kernel_limit_disk, "LIBCUDF_KERNEL_CACHE_LIMIT_DISK");

auto cache_dir = get_program_cache_dir();

if (kernel_limit_disk == 0) { cache_dir = {}; }

auto res = caches.insert({preprog.name(),
std::make_unique<jitify2::ProgramCache<>>( //
kernel_limit_proc,
preprog,
nullptr,
cache_dir,
kernel_limit_disk)});

existing_cache = res.first;
}
Expand Down