Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some APIs to help with out of core joins in Spark [skip ci] #8118

Merged
merged 3 commits into from
May 1, 2021
Merged

Some APIs to help with out of core joins in Spark [skip ci] #8118

merged 3 commits into from
May 1, 2021

Conversation

revans2
Copy link
Contributor

@revans2 revans2 commented Apr 29, 2021

It adds a simple prefix sum for doing size calculations. It also changes a few APIs so that they take a ColumnView instead of a ColumnVector.

@revans2 revans2 added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 29, 2021
@revans2 revans2 self-assigned this Apr 29, 2021
@revans2 revans2 requested a review from a team as a code owner April 29, 2021 22:57
@github-actions github-actions bot added the CMake CMake build issue label Apr 29, 2021
@revans2 revans2 mentioned this pull request Apr 29, 2021
Merged
jlowe
jlowe approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits but otherwise lgtm.

java/src/main/native/src/ColumnViewJni.cpp Outdated Show resolved Hide resolved
java/src/main/native/src/prefix_sum.cu Outdated Show resolved Hide resolved
@revans2
Copy link
Contributor Author

revans2 commented May 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cf8c73a into rapidsai:branch-0.20 May 1, 2021
@revans2 revans2 deleted the out_of_core_join_helps branch May 1, 2021 22:43
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia left review comments

@jlowe jlowe jlowe approved these changes

Assignees

@revans2 revans2

Labels
4 - Needs Review Waiting for reviewer to review or respond CMake CMake build issue improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@revans2 @jlowe @ttnghia @vyasr