Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cupy.ndarray (without core) #8114

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Use cupy.ndarray (without core) #8114

merged 1 commit into from
Apr 29, 2021

Conversation

jakirkham
Copy link
Member

core is internal to cupy and renamed to reflect that in CuPy 9. However that shouldn't be needed to access ndarray as it is imported at the top-level. So just use cupy.ndarray.

cc @kkraus14 @rjzamora

@jakirkham jakirkham requested a review from a team as a code owner April 29, 2021 18:32
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 29, 2021
@kkraus14 kkraus14 added bug Something isn't working non-breaking Non-breaking change tests Unit testing for project labels Apr 29, 2021
@kkraus14
Copy link
Collaborator

@gpucibot merge

@razajafri razajafri mentioned this pull request Apr 29, 2021
Merged
galipremsagar
galipremsagar reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@galipremsagar galipremsagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to change in these files too:

https://github.com/rapidsai/cudf/blob/branch-0.20/python/cudf/cudf/core/algorithms.py#L56

and all the 6 occurences of cp.core.core.ndarray in : https://github.com/rapidsai/cudf/blob/branch-0.20/python/cudf/cudf/tests/test_factorize.py

@jakirkham
Use cupy.ndarray (without core)
ca18f6d 
`core` is internal to `cupy` and renamed to reflect that in CuPy 9.
However that shouldn't be needed to access `ndarray` as it is `import`ed
at the top-level. So just use `cupy.ndarray`.
@jakirkham
Copy link
Member Author

Good catch Prem! 😄 Should be fixed above. Can you please take another look? 🙂

@galipremsagar
Copy link
Contributor

@gpucibot merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021 •
edited
Loading

Codecov Report

Merging #8114 (ca18f6d) into branch-0.20 (51336df) will increase coverage by 0.02%.
The diff coverage is 92.81%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8114      +/-   ##
===============================================
+ Coverage        82.88%   82.91%   +0.02%     
===============================================
  Files              103      103              
  Lines            17668    17868     +200     
===============================================
+ Hits             14645    14816     +171     
- Misses            3023     3052      +29
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/tools/datetimes.py 80.42% <ø> (-4.11%) ⬇️
python/cudf/cudf/core/window/rolling.py 88.88% <ø> (+0.65%) ⬆️
python/cudf/cudf/io/orc.py 86.89% <ø> (ø)
python/cudf/cudf/utils/applyutils.py 100.00% <ø> (+1.25%) ⬆️
python/cudf/cudf/utils/cudautils.py 57.75% <ø> (ø)
python/cudf/cudf/utils/dtypes.py 81.87% <ø> (-1.57%) ⬇️
python/cudf/cudf/utils/utils.py 90.00% <ø> (+0.49%) ⬆️
python/dask_cudf/dask_cudf/backends.py 89.51% <ø> (-0.08%) ⬇️
python/dask_cudf/dask_cudf/groupby.py 92.64% <ø> (+0.49%) ⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1757d10...ca18f6d. Read the comment docs.

@rapids-bot rapids-bot bot merged commit cea6c20 into rapidsai:branch-0.20 Apr 29, 2021
@jakirkham jakirkham deleted the drop_core_cp branch April 30, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API. tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakirkham @kkraus14 @galipremsagar