Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners for benchmarks / tests CMake [skip ci] #8066

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

kkraus14
Copy link
Collaborator

Updates the github CODEOWNERS file to make the benchmarks and tests CMake files fall under the cpp codeowners instead of the cmake codeowners.

@kkraus14 kkraus14 added gpuCI CMake CMake build issue labels Apr 26, 2021
@kkraus14 kkraus14 requested a review from a team as a code owner April 26, 2021 20:55
@kkraus14 kkraus14 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 26, 2021
@github-actions github-actions bot removed CMake CMake build issue gpuCI labels Apr 26, 2021
@kkraus14 kkraus14 changed the title Update codeowners for benchmarks / tests CMake Update codeowners for benchmarks / tests CMake [skip ci] Apr 26, 2021
@kkraus14
Copy link
Collaborator Author

rerun tests

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #8066 (dd8fe33) into branch-0.20 (51336df) will decrease coverage by 0.05%.
The diff coverage is 84.61%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8066      +/-   ##
===============================================
- Coverage        82.88%   82.83%   -0.06%     
===============================================
  Files              103      103              
  Lines            17668    17801     +133     
===============================================
+ Hits             14645    14746     +101     
- Misses            3023     3055      +32     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/io/orc.py 86.89% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 57.75% <25.00%> (ø)
python/cudf/cudf/utils/dtypes.py 81.87% <41.66%> (-1.57%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.43% <72.72%> (ø)
python/cudf/cudf/core/tools/datetimes.py 80.25% <74.69%> (-4.28%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 91.55% <76.92%> (+0.11%) ⬆️
python/cudf/cudf/core/column/decimal.py 90.83% <77.27%> (-2.09%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.51% <80.00%> (-0.08%) ⬇️
python/cudf/cudf/core/column/column.py 88.64% <83.33%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ace5ec...dd8fe33. Read the comment docs.

@kkraus14
Copy link
Collaborator Author

cc @harrism @robertmaynard

@harrism
Copy link
Member

harrism commented Apr 27, 2021

Is there a reason to wait to merge this?

@ttnghia
Copy link
Contributor

ttnghia commented Apr 27, 2021

Rerun tests.

@kkraus14
Copy link
Collaborator Author

Is there a reason to wait to merge this?

Nope, just wanted someone to review my changes to the CODEOWNERS pattern

@kkraus14
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4d359c2 into rapidsai:branch-0.20 Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants