Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't reindex an new value on setitem if the original dataframe was empty #8026

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Don't reindex an new value on setitem if the original dataframe was empty #8026

merged 3 commits into from
Apr 22, 2021

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 21, 2021

This PR resolves #8023. The pandas compatibility patch in #7948 (and the backport to 0.19 in #7957) also needs to handle the case of assigning to an empty DataFrame.

@vyasr vyasr requested a review from a team as a code owner April 21, 2021 23:56
@vyasr vyasr requested review from shwina and galipremsagar April 21, 2021 23:56
@vyasr vyasr self-assigned this Apr 21, 2021
@github-actions github-actions bot added the Python Affects Python cuDF API. label Apr 21, 2021
@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API. and removed Python Affects Python cuDF API. labels Apr 21, 2021
shwina
shwina approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@shwina shwina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vyasr vyasr changed the base branch from branch-0.20 to branch-0.19 April 22, 2021 00:08
@vyasr vyasr requested a review from kkraus14 April 22, 2021 00:13
galipremsagar
galipremsagar requested changes Apr 22, 2021
View reviewed changes
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from galipremsagar April 22, 2021 01:43
@codecov
Copy link

codecov bot commented Apr 22, 2021 •
edited
Loading

Codecov Report

Merging #8026 (8bee629) into branch-0.19 (cdf7704) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.19    #8026   +/-   ##
============================================
  Coverage        82.74%   82.74%           
============================================
  Files              103      103           
  Lines            17702    17702           
============================================
  Hits             14648    14648           
  Misses            3054     3054
Impacted Files Coverage Δ
python/cudf/cudf/core/dataframe.py 90.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf7704...8bee629. Read the comment docs.

@galipremsagar galipremsagar added ! - Release 5 - Ready to Merge Testing and reviews complete, ready to merge labels Apr 22, 2021
@kkraus14 kkraus14 added ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround and removed ! - Release labels Apr 22, 2021
@raydouglass raydouglass merged commit 86897fb into rapidsai:branch-0.19 Apr 22, 2021
@vyasr vyasr deleted the fix/issue_8023 branch January 14, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina shwina approved these changes

Assignees

@vyasr vyasr

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge ! - Hotfix Hotfix is a bug that affects the majority of users for which there is no reasonable workaround bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 0.19 cudf empty df assignment issues
5 participants
@vyasr @shwina @kkraus14 @galipremsagar @raydouglass