Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dask_cudf metadata-inference when first ORC path is empty #8021

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Fix dask_cudf metadata-inference when first ORC path is empty #8021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/dask_cudf/dask_cudf/io/orc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,12 @@ def read_orc(path, columns=None, filters=None, storage_options=None, **kwargs):
columns = list(schema)

with fs.open(paths[0], "rb") as f:
meta = cudf.read_orc(f, stripes=[0], columns=columns, **kwargs)
meta = cudf.read_orc(
f,
stripes=[0] if nstripes_per_file[0] else None,
columns=columns,
**kwargs,
)

name = "read-orc-" + tokenize(fs_token, path, columns, **kwargs)
dsk = {}
Expand Down
21 changes: 19 additions & 2 deletions python/dask_cudf/dask_cudf/io/tests/test_orc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@

from dask import dataframe as dd

import dask_cudf

import cudf

import dask_cudf

# import pyarrow.orc as orc

cur_dir = os.path.dirname(__file__)
Expand Down Expand Up @@ -74,6 +74,23 @@ def test_read_orc_filtered(tmpdir, engine, predicate, expected_len):
dd.assert_eq(len(df), expected_len)


def test_read_orc_first_file_empty(tmpdir):

# Write a 3-file dataset where the first file is empty
# See: https://github.com/rapidsai/cudf/issues/8011
path = str(tmpdir)
os.makedirs(path, exist_ok=True)
df1 = cudf.DataFrame({"id": [1, 2], "float": [1.0, 2.0]})
df1.iloc[:0].to_orc(os.path.join(path, "data.0"))
df1.iloc[:1].to_orc(os.path.join(path, "data.1"))
df1.iloc[1:].to_orc(os.path.join(path, "data.2"))

# Read back the files with dask_cudf,
# and check the result.
df2 = dask_cudf.read_orc(os.path.join(path, "*"))
dd.assert_eq(df1, df2, check_index=False)


@pytest.mark.parametrize("compute", [True, False])
@pytest.mark.parametrize("compression", [None, "snappy"])
@pytest.mark.parametrize(
Expand Down