Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Java API change for supporting structs (#7730)" #7987

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

razajafri
Copy link
Contributor

This reverts commit 3327f7b.

We have to revert this because the dependent project is broken and my system is in a broken state.

@razajafri razajafri requested review from a team as code owners April 16, 2021 22:39
@github-actions github-actions bot added Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Apr 16, 2021
@razajafri razajafri added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Apr 16, 2021
@rongou
Copy link
Contributor

rongou commented Apr 16, 2021

@gpucibot merge

@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #7987 (a7fb3e2) into branch-0.20 (51336df) will increase coverage by 0.01%.
The diff coverage is 87.77%.

❗ Current head a7fb3e2 differs from pull request most recent head 5977b1d. Consider uploading reports for the commit 5977b1d to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7987      +/-   ##
===============================================
+ Coverage        82.88%   82.90%   +0.01%     
===============================================
  Files              103      103              
  Lines            17668    17655      -13     
===============================================
- Hits             14645    14637       -8     
+ Misses            3023     3018       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 57.75% <25.00%> (ø)
python/cudf/cudf/core/column/column.py 88.64% <71.42%> (ø)
python/cudf/cudf/core/column/numerical.py 94.43% <72.72%> (ø)
python/cudf/cudf/core/dataframe.py 90.87% <83.33%> (+0.01%) ⬆️
python/cudf/cudf/utils/utils.py 89.53% <91.66%> (+0.02%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.91% <100.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 88.66% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 92.28% <100.00%> (+0.83%) ⬆️
python/cudf/cudf/core/index.py 93.07% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3327f7b...5977b1d. Read the comment docs.

@razajafri
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@razajafri
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 867d6ee into rapidsai:branch-0.20 Apr 17, 2021
@razajafri razajafri deleted the parquet_struct_revert branch April 17, 2021 01:33
@mythrocks
Copy link
Contributor

Merged, at last! I wonder why it took that long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants