Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CPM with fix for FETCHCONTENT_BASE_DIR #7982

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

trxcllnt
Copy link
Contributor

Update CPM with a fix for FETCHCONTENT_BASE_DIR.

@trxcllnt trxcllnt requested a review from a team as a code owner April 16, 2021 18:47
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Apr 16, 2021
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 16, 2021
@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Apr 16, 2021
@trxcllnt
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #7982 (d8bf22a) into branch-0.20 (51336df) will decrease coverage by 0.37%.
The diff coverage is 87.64%.

❗ Current head d8bf22a differs from pull request most recent head 0c299df. Consider uploading reports for the commit 0c299df to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7982      +/-   ##
===============================================
- Coverage        82.88%   82.51%   -0.38%     
===============================================
  Files              103      103              
  Lines            17668    17296     -372     
===============================================
- Hits             14645    14272     -373     
- Misses            3023     3024       +1     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 55.04% <25.00%> (-2.72%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.41% <70.00%> (-0.02%) ⬇️
python/cudf/cudf/core/column/column.py 88.48% <71.42%> (-0.17%) ⬇️
python/cudf/cudf/core/dataframe.py 90.75% <83.33%> (-0.11%) ⬇️
python/cudf/cudf/utils/utils.py 89.47% <91.66%> (-0.04%) ⬇️
python/cudf/cudf/core/column/datetime.py 89.40% <100.00%> (-0.52%) ⬇️
python/cudf/cudf/core/column/timedelta.py 88.33% <100.00%> (-0.34%) ⬇️
python/cudf/cudf/core/groupby/groupby.py 92.12% <100.00%> (+0.67%) ⬆️
python/cudf/cudf/core/index.py 92.62% <100.00%> (-0.46%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3327f7b...0c299df. Read the comment docs.

@kkraus14
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ed68e96 into rapidsai:branch-0.20 Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants