-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python bindings for get_json_object
#7981
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7981 +/- ##
===============================================
- Coverage 82.88% 82.88% -0.01%
===============================================
Files 103 104 +1
Lines 17668 17894 +226
===============================================
+ Hits 14645 14832 +187
- Misses 3023 3062 +39
Continue to review full report at Codecov.
|
If this kind of JSON in tests is a one-off, then the suggestions on this thread are probably fine. On the other hand, if there are multiple tests that require JSON data (I'm not sure) it might make sense to toss those into separate JSON files that are loaded into the tests. |
@gpucibot merge |
Fixes: 7916