Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python bindings for get_json_object #7981

Merged
merged 27 commits into from
May 6, 2021

Conversation

skirui-source
Copy link
Contributor

Fixes: 7916

@skirui-source skirui-source added feature request New feature or request 2 - In Progress Currently a work in progress Python Affects Python cuDF API. Cython labels Apr 16, 2021
@skirui-source skirui-source requested a review from kkraus14 April 16, 2021 18:44
@skirui-source skirui-source self-assigned this Apr 16, 2021
@skirui-source skirui-source added the non-breaking Non-breaking change label Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #7981 (36a0cab) into branch-0.20 (51336df) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7981      +/-   ##
===============================================
- Coverage        82.88%   82.88%   -0.01%     
===============================================
  Files              103      104       +1     
  Lines            17668    17894     +226     
===============================================
+ Hits             14645    14832     +187     
- Misses            3023     3062      +39     
Impacted Files Coverage Δ
python/cudf/cudf/_fuzz_testing/parquet.py 0.00% <ø> (ø)
python/cudf/cudf/_fuzz_testing/utils.py 0.00% <ø> (ø)
python/cudf/cudf/core/abc.py 91.66% <ø> (+0.17%) ⬆️
python/cudf/cudf/core/algorithms.py 82.35% <ø> (ø)
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/core/column/categorical.py 92.37% <ø> (+0.13%) ⬆️
python/cudf/cudf/core/column/column.py 88.20% <ø> (-0.44%) ⬇️
python/cudf/cudf/core/column/datetime.py 88.03% <ø> (-1.88%) ⬇️
python/cudf/cudf/core/tools/datetimes.py 80.42% <0.00%> (-4.11%) ⬇️
python/cudf/cudf/core/column/decimal.py 91.04% <0.00%> (-1.89%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f21b3...36a0cab. Read the comment docs.

@skirui-source skirui-source marked this pull request as ready for review April 22, 2021 06:16
@skirui-source skirui-source requested a review from a team as a code owner April 22, 2021 06:16
@skirui-source skirui-source requested a review from shwina April 22, 2021 06:16
@skirui-source skirui-source added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 23, 2021
@skirui-source skirui-source requested a review from shwina April 23, 2021 00:06
@vyasr
Copy link
Contributor

vyasr commented Apr 30, 2021

If this kind of JSON in tests is a one-off, then the suggestions on this thread are probably fine. On the other hand, if there are multiple tests that require JSON data (I'm not sure) it might make sense to toss those into separate JSON files that are loaded into the tests. pre-commit has hooks that can be used to validate and auto-format JSON in that case (search for check-json and pretty-format-json on the page listing pre-commit hooks).

@skirui-source skirui-source requested a review from shwina May 3, 2021 18:24
@skirui-source skirui-source requested review from shwina and kkraus14 May 5, 2021 01:58
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_string.py Outdated Show resolved Hide resolved
@skirui-source skirui-source requested a review from kkraus14 May 5, 2021 20:48
@skirui-source skirui-source requested a review from kkraus14 May 6, 2021 03:02
@kkraus14
Copy link
Collaborator

kkraus14 commented May 6, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 8ae73d5 into rapidsai:branch-0.20 May 6, 2021
@skirui-source skirui-source deleted the json-object branch May 6, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Python bindings for get_json_object
5 participants