Fix automerge 0.19 --> 0.20 #7979

kkraus14 · 2021-04-16T14:50:44Z

* Reindex in `DataFrame.__setitem__` (rapidsai#7948) This PR fixes missing reindexing in `DataFrame.__setitem__` when the `value` argument is a `DataFrame`, we currently align index if `value` is a Series & `arg` is a column name already. This change is necessary to continue with the upgrade to pandas `1.2.4`, however pandas has confirmed this as a regression only in `1.2.0` and `1.2.2` hence corrected the pytest to only xfail in those versions of pandas. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: rapidsai#7948 * pin max pandas to 1.2.4

codecov · 2021-04-16T16:47:23Z

Codecov Report

Merging #7979 (51336df) into branch-0.20 (599f62d) will increase coverage by 0.58%.
The diff coverage is 92.04%.

@@               Coverage Diff               @@
##           branch-0.20    #7979      +/-   ##
===============================================
+ Coverage        82.30%   82.88%   +0.58%     
===============================================
  Files              101      103       +2     
  Lines            17053    17668     +615     
===============================================
+ Hits             14035    14645     +610     
- Misses            3018     3023       +5

Impacted Files	Coverage Δ
python/cudf/cudf/utils/dtypes.py	`83.44% <ø> (-6.45%)`	⬇️
python/cudf/cudf/utils/utils.py	`89.50% <ø> (+4.44%)`	⬆️
python/cudf/cudf/core/column/lists.py	`87.41% <80.00%> (+0.19%)`	⬆️
python/cudf/cudf/core/groupby/groupby.py	`91.44% <80.95%> (-2.01%)`	⬇️
python/cudf/cudf/core/column/column.py	`88.64% <86.20%> (+1.20%)`	⬆️
python/cudf/cudf/core/column/struct.py	`96.29% <86.66%> (-3.71%)`	⬇️
python/cudf/cudf/core/index.py	`93.07% <88.37%> (+0.05%)`	⬆️
python/cudf/cudf/core/column/decimal.py	`92.92% <91.48%> (-0.92%)`	⬇️
python/cudf/cudf/core/column/interval.py	`91.11% <92.30%> (+0.48%)`	⬆️
python/cudf/cudf/core/join/join.py	`96.75% <93.75%> (+0.24%)`	⬆️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a666a0...51336df. Read the comment docs.

galipremsagar and others added 2 commits April 16, 2021 10:20

Merge branch 'branch-0.19' into fix_automerge

51336df

kkraus14 requested review from a team as code owners April 16, 2021 14:50

kkraus14 requested review from galipremsagar and brandon-b-miller April 16, 2021 14:50

github-actions bot added conda Python Affects Python cuDF API. labels Apr 16, 2021

galipremsagar approved these changes Apr 16, 2021

View reviewed changes

ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 16, 2021

raydouglass approved these changes Apr 16, 2021

View reviewed changes

dillon-cullinan merged commit 025c56a into rapidsai:branch-0.20 Apr 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix automerge 0.19 --> 0.20 #7979

Fix automerge 0.19 --> 0.20 #7979

kkraus14 commented Apr 16, 2021

codecov bot commented Apr 16, 2021 •

edited

Loading

Fix automerge 0.19 --> 0.20 #7979

Fix automerge 0.19 --> 0.20 #7979

Conversation

kkraus14 commented Apr 16, 2021

codecov bot commented Apr 16, 2021 • edited Loading

Codecov Report

codecov bot commented Apr 16, 2021 •

edited

Loading